[MGNLFE-58] Allow using dialog at area level Created: 26/Jun/20 Updated: 08/Sep/20 Resolved: 21/Jul/20 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | Template Annotations |
| Affects Version/s: | 1.0.4 |
| Fix Version/s: | 1.0.5 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Adrien Manzoni | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 4 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||||||||
| Documentation update required: |
Yes
|
||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||
| Epic Link: | SPA Editor | ||||||||||||||||||||||||||||||||||||
| Sprint: | HL & LD 7 | ||||||||||||||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Many customers use the area as a single fixed component. The template definition framework allows you to assign a dialog to an area. However, the [TemplationAnnotations|https://git.magnolia-cms.com/projects/MODULES/repos/frontend-helpers/browse/packages/template-annotations/src/service/TemplateAnnotations.js] util does not seem to allow it. Please release frontend libraries to npm as soon as ticket is fixed. |
| Comments |
| Comment by Bartosz Staryga [ 29/Jun/20 ] |
|
This feature would need the extending of area rendering script itself. Currently area is hardcoded as looping over the all components. We need to add the ability to have custom area scripts (like templateScript in freemarker). It could be e.g. component passed as prop: |
| Comment by Christopher Zimmermann [ 30/Jun/20 ] |
|
Improvement is accepted. This is commonly used as a way of improving the user experience of authoring because it provides an edit icon directly in the page where the editing will be applied. (as opposed to adding it to the page properties dialog.) And of course having it on the area makes it easily re-usable in other pages. |
| Comment by Christopher Zimmermann [ 30/Jun/20 ] |
|
UPDATE:
Please consider if 'noComponent' needs to be supported. https://documentation.magnolia-cms.com/display/DOCS62/Area+definition |
| Comment by Bartosz Staryga [ 10/Jul/20 ] |
|
czimmermann imho why not |