[MGNLFE-62] EditableArea is rendering a mgnlEditorBar at noComponent Area Created: 24/Jul/20  Updated: 24/Nov/20  Resolved: 24/Nov/20

Status: Closed
Project: Magnolia Frontend Helpers
Component/s: None
Affects Version/s: 1.0.4
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Viet Nguyen Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: 622
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Bildschirmfoto 2020-07-22 um 22.28.36-1.png    
Issue Links:
Relates
relates to MGNLFE-65 SPA Editor: Magnolia area dialog is d... Closed
causality
is causing PAGES-352 Provide endpoint for template annotat... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: SPA Editor

 Description   

The react-editor is rendering a mgnlEditorBar at noComponent area.
Validate angular as well.

Reproduction:

  • Create an area dialogue with a multi-value field 
    form:
      properties:
        logo:
          $type: linkField
          chooser:
            workbenchChooser:
              appName: dam-chooser
        metaNavigation:
          $type: jcrMultiField
          itemProvider:
            $type: jcrChildNodeProvider
          field:
            $type: compositeField
            properties:
              label:
                $type: textField
                required: true
              href:
                !include:/test-core/includes/fields/extendedLinkField.yaml
                required: true
  • add multiple links
  • the frontend is rendering a mgnlEditorBar at the multi-value node

 

 

Expected:

  • "<!--cms:component content="website:/demo-content/header/metaNavigation" label="" description="" activationStatus="0"–>" should only be rendered for mgnl:component nodes.
  • A solution could be, the EditableArea skip rendering the components if the type is noComponent 
    areas:
      header:
        title: Header Area
        dialog: test-core:areas/header
        editable: false
        type: noComponent
        inheritance:
          components: all
          enabled: true
          properties: all
    

Generated at Mon Feb 12 05:43:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.