[MGNLFE-84] peerDependencies in npm 7 prevent installing of react-editor Created: 18/Nov/20 Updated: 21/Jan/21 Resolved: 12/Jan/21 |
|
| Status: | Closed |
| Project: | Magnolia Frontend Helpers |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0.6 |
| Type: | Bug | Priority: | High |
| Reporter: | Bartosz Staryga | Assignee: | Canh Nguyen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3.25d | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Epic Link: | SPA Editor |
| Sprint: | HL & LD 18, HL & LD 19, HL & LD 20 |
| Story Points: | 2 |
| Description |
Steps to reproduceMake sure you run npm in version 7. Expected results@magnolia/react-editor installed correctly. Actual resultsError: npm ERR! A complete log of this run can be found in: Workaroundnpm install @magnolia/react-editor --legacy-peer-deps Development notesOnly react-editor has those dependencies, angular one lacks it. Info about changes in new npm: Node and npm versions:https://nodejs.org/en/download/releases/ Npm 7 is shipped with Node 15, the actual current version of node. |
| Comments |
| Comment by Robert Šiška [ 04/Jan/21 ] |
|
Angular-editor does contain peer dependencies as well, and it fails on the same error.
$ npm install @angular/cli
$ ng new my-app
$ cd my-app
$ npm install @magnolia/angular-editor
|
| Comment by Christopher Zimmermann [ 05/Jan/21 ] |
|
rsiska Do you think we should create a new ticket for that error? Sounds like its the same bad experience as with React? |
| Comment by Robert Šiška [ 11/Jan/21 ] |
|
No, we have solution for both - I was just elaborating on the Acceptance Criteria. |