[MGNLFORM-19] Review exception handling with FormProcessors Created: 04/Jun/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia Form Module
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File FORM-19.exception.txt    
Issue Links:
relation
is related to MGNLFORM-25 Improve form error handling Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

It might not be related directly to the form processors; but the newsletter's implementations for instance, catch all exception thrown in their business logic code, and log them. There is no way for the actual error to bubble up to the form rendering (i.e form error messages seem static while they could be more dynamic). As a result, these exceptions are lost, and the processor has to log it.



 Comments   
Comment by Magnolia International [ 04/Jun/09 ]

See the log extract in attachment. These are 2 different stacktraces, while the first one should "ideally" be nested in the second one (if the latter was useful at all)

Comment by Magnolia International [ 29/Jul/09 ]

The original aim of this issue report was to do an actual code review and possibly change how exceptions are handled and passed around (or not); hence the fix version set 1.1.
Fix done here is fine for a 1.0.2, but we still do need the review - could you please split the ticket in 2, then ? Cheers,

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 05:36:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.