[MGNLFORM-42] The separator for multi-value form parameters should be configurable Created: 18/Dec/09  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia Form Module
Component/s: field, state consistancy
Affects Version/s: 1.0.3
Fix Version/s: 1.4.x, 2.2.x

Type: Improvement Priority: Major
Reporter: Will Scheidegger Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: multi-value, next, parameter, quickwin
Remaining Estimate: 10m
Time Spent: Not Specified
Original Estimate: 10m

Attachments: Text File multiValueSeparator.patch    
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

With the simple patch attached to this issue one can configure the separator used for multi-value form parameters. At the moment, the separator is hardcoded to "__", so selecting 3 checkboxes will result in "value1__value2__value3" in mail forms etc. where it could easily be "value1, value2, value3" or anything.

The configuration is done in the form processor of paragraph configuration.



 Comments   
Comment by Philipp Bärfuss [ 22/Dec/09 ]

We should probably use something more meaning full, like encoding the values to ensure that they don't contain the separator

Comment by Christopher Zimmermann [ 03/Dec/13 ]

I think its ok to let the implementor specify the separtor.
Encoding the values could be problematic - how or where would you unencode them.
I would comment the code to warn of the danger of the values including the separator -and as a safety measure I would parse all values and remove the separator value from them.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 05:36:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.