As an admin, i have a magnolia-5-content-app to administrate the forums (MGNLFORUM-189)

[MGNLFORUM-193] Create M5-App and a Content-App as 1st sub-app to browse and moderate Forums, Threads and Messages Created: 09/Dec/13  Updated: 12/Mar/14  Resolved: 12/Mar/14

Status: Closed
Project: Forum (closed)
Component/s: dialogs, moderation
Affects Version/s: None
Fix Version/s: 3.3

Type: Sub-task Priority: Major
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLFORUM-201 Do not allow / prevent deleting of th... Closed
depends upon MGNLFORUM-205 create and configure Actions for dele... Closed
depends upon MGNLFORUM-206 create and configure Actions, Command... Closed
depends upon MGNLFORUM-207 do not allow to create sub-forums; cr... Closed
depends upon MGNLFORUM-208 ask for confirmation when deleting a ... Closed
depends upon MGNLFORUM-209 customize appClass to open browser-su... Closed
depends upon MGNLFORUM-210 Configure actions for the 1st subApp ... Closed
depends upon MGNLFORUM-215 i18n: replace hardcoded Texts in the ... Closed
depends upon MGNLFORUM-212 automatically create roles when a new... Closed
relation
is related to MGNLFORUM-191 An App to Edit Comments Closed
Template:
Date of First Response:

 Description   

Create M5-App and a Content-App as 1st sub-app to browse and moderate Forums, Threads and Messages.



 Comments   
Comment by Daniel Lipp [ 10/Jan/14 ]

Lots of things to fix:

  • many new classes don't have proper javadoc (TODO:write a better description here)
  • ton's of todo's added -> if the ticket is resolved one would assume it's all done - if there's open issues rather create dedicated tickets
  • many new classes are added but not a single unit test
  • branch doesn't even build because of failures of existing tests
  • commits should be cleaned/squashed: e.g. commit messages like "apps-config, appLauncher-conf, actions ... (not working yet)" should not go to master

btw: module doesn't have a coverage threshold yet

Comment by Espen Jervidalo [ 05/Feb/14 ]

info.magnolia.module.forum.admin.action.ForumCommandAction#getFailureMessage use i18n

e.g. info.magnolia.module.forum.admin.action.DeleteMessageAction#getParentThread use constants
for mgnl:thread, mgnl:message etc from info.magnolia.module.forum.DefaultForumManager

info.magnolia.module.forum.admin.availability.InvalidatableRule#allow add @Override

info.magnolia.module.forum.app.column.* fix javadoc
info.magnolia.module.forum.app.column.ForumColumnDefinition - used? -> remove it

info.magnolia.module.forum.app.ForumContentApp javadoc

move app related classes, like action, availability to app package.

Comment by Christoph Meier [ 06/Feb/14 ]

ForumColumnDefinition is used in configuration; cannot remove it (=> reviewer)

Comment by Christoph Meier [ 17/Feb/14 ]

Note: On master-branch, all commits have been splitted up to only 5 commits against 5 tickets.
Most of the things are committed against MGNLFORUM-193 this one.

Comment by Milan Divilek [ 11/Mar/14 ]

Reopen:
Edit forum action (/modules/forum/apps/forum/subApps/browser/actions/editForum/) is available only for forum-admin-base role, but this role doesn't exist. This action should be available for forum-ALL-admin role instead of forum-admin-base.

addForum, deleteForum action should be available only for forum-ALL-admin. Moderators should not have this actions available.

Comment by Christoph Meier [ 12/Mar/14 ]

Note to the reviewer:
"addForum, deleteForum action should be available only for admin" => I had this once but then removed it since i was told to make it really simple; but bow brought it back since it really makes sense.

Generated at Mon Feb 12 02:01:36 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.