As an admin, i have a magnolia-5-content-app to administrate the forums (MGNLFORUM-189)

[MGNLFORUM-195] Create VersionHandler-Tasks to ensure proper working of already existing 1.3.x-Forums Created: 09/Dec/13  Updated: 06/Mar/14  Resolved: 24/Feb/14

Status: Closed
Project: Forum (closed)
Component/s: VersionHandler
Affects Version/s: None
Fix Version/s: 3.3

Type: Sub-task Priority: Neutral
Reporter: Christoph Meier Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLCMNT-90 Create VersionHandler-Tasks to ensure... Closed
Template:
Date of First Response:

 Description   

Create VersionHandler-Tasks to ensure proper working of already existing 1.3.x-Forums. See the concept-page for the details: http://wiki.magnolia-cms.com/pages/viewpage.action?pageId=77463782#Concept-ForumCommentingonM5-Updatetasks

Amongst others, this means:



 Comments   
Comment by Christoph Meier [ 30/Jan/14 ]

The 2 tickets in the description above have no influence of what the VersionHandler for 3.3 must take care for.

Version handler for 3.3 now does mainly adding a Delta which is:

  • adding the conf. for the new app(s) /modules/forum/apps
  • applauncher-conf. to launch /modules/forum/apps/forum
  • migrating the existing dialogs and adding 2 new ones

Probably custom installed apps gets moved to /modules/forum/apps_old

Comment by Christoph Meier [ 30/Jan/14 ]

Instead of replacing the dialogs: use the DialogMigrationTasks!

Comment by Christoph Meier [ 01/Feb/14 ]

make sure that the users which come with bootstrap-samples (forummod, forumadmin, forumuser) are added, too.

Comment by Christoph Meier [ 11/Feb/14 ]

Must reopen since granting permissions must be moved to magnolia-demo-project

Comment by Roman Kovařík [ 19/Feb/14 ]
  • Update currently fails with
    [INFO] [talledLocalContainer] info.magnolia.module.delta.TaskExecutionException: Could not bootstrap: Can't find resource to bootstrap at /mgnl-bootstrap/forum/config.modules.adminInterface.config.securityConfiguration.repositories.forum.xml
    
    • ForumModuleVersionHandlerTest currently tests only update from 3.2.1, so the test class doesn't reveal this failure.
    • The good behaviour is to test also clean install (executeUpdatesAsIfTheCurrentlyInstalledVersionWas(null);)

Typo in the task name: Bootstrap appLaucnher-layout conf.

Comment by Christoph Meier [ 20/Feb/14 ]

DeltaBuilder.update("3.2.1") i sno more meaningful (never was); it tried to update custom sec. conf. which is not supoorted in M5. =>

  • removing DeltaBuilder.update("3.2.1")
  • remove the bootstrap-file used in DeltaBuilder.update("3.2.1")
  • remove the custom sec. conf.-node if it exists (/modules/adminInterface/config/securityConfiguration/repositories/forum)
Comment by Roman Kovařík [ 20/Feb/14 ]
  1. You forgot to remove delta "3.2.1".
  2. Please add test of version handler to check if it really fixes the issue
    (executeUpdatesAsIfTheCurrentlyInstalledVersionWas(Version.parseVersion("1.3")); for example).
Comment by Roman Kovařík [ 20/Feb/14 ]

Good, the update doesn't fail now, but we have still differences in configuration between fresh and migrated isntance:
http://hudson.magnolia-cms.com/view/X/job/m_4-5-migration_2.0.x-branch_with_integration_tests/ws/magnolia-migration-integration/diff-reports/config.modules.forum.html

  • Different configuration on updated instance has read color.
  • Different configuration on fresh instance has green color.
Comment by Roman Kovařík [ 24/Feb/14 ]

Resolved:

Generated at Mon Feb 12 02:01:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.