[MGNLFORUM-220] fix DefaultForumManagerTest Created: 15/Jan/14 Updated: 19/Feb/14 Resolved: 17/Feb/14 |
|
| Status: | Closed |
| Project: | Forum (closed) |
| Component/s: | persistence, security |
| Affects Version/s: | None |
| Fix Version/s: | 3.3 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Christoph Meier |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
fix DefaultForumManagerTest#testCreatingForumShouldUseUniqueCleanUpNameAndAddTitleProperty java.lang.AssertionError: java.lang.AssertionError: |
| Comments |
| Comment by Christoph Meier [ 23/Jan/14 ] |
|
As long as this forum depends on magnolia-core 5.2, but not higher, the test works fine. |
| Comment by Christoph Meier [ 05/Feb/14 ] |
|
since we want to have dependecy to 5.2.2, this must be "fixed", therefore reopenend. |
| Comment by Jan Haderka [ 13/Feb/14 ] |
|
While the use of deprecated API in the test might be forced by code under the test that was not updated yet, there is no reason for not replacing EasyMock with Mockito for the tests that are being modified. |
| Comment by Christoph Meier [ 17/Feb/14 ] |
|
Changing from Easymock- to Mockito-Framework was not completely trivial; many of the test would must have been changed significant. |
| Comment by Daniel Lipp [ 17/Feb/14 ] |
|
DefaultForumManagerTest
AbstractForumRepositoryTestCase
(btw: unless there's more subclasses of AbstractForumRepositoryTestCase coming soon, I'd merge that code into DefaultForumManagerTest |