[MGNLFORUM-221] UX: group-actions, use correct items, correct wording, etc. according to the guidelines Created: 16/Jan/14  Updated: 20/Feb/14  Resolved: 13/Feb/14

Status: Closed
Project: Forum (closed)
Component/s: Admin-UI, UX
Affects Version/s: None
Fix Version/s: 3.3

Type: Task Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-2633 Install icons for "lock" and "unlock"... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Mixed ticket for the UX-aspects (see (according to http://documentation.magnolia-cms.com/display/DOCS/App+design+guidelines))

overview

  • group-actions
  • use correct icons
  • correct wording, etc.

Icons:

  • icon-forums
  • ...


 Comments   
Comment by Christoph Meier [ 04/Feb/14 ]
  • Lock/unlock icons
  • Order of actions when thread is selected:
    • edit thread, delete thread ; lock thread, unlock thread
  • add proper labels in dialogs: no underscores or dashes in label names (saw this in "edit thread" dialog)
  • add proper titles and headers in demo content: same as with labels in dialogs: no dashes in titles, please

And on true/false in columns

  • for validated: using mark/unmark (like for the action) an "nothing" if it's not yet decided
  • for locked: show the lock only if it's locked
Comment by Christopher Zimmermann [ 12/Feb/14 ]

Please correct spelling on two class files:
LockedColoumnFormatter.java
ValidatedColoumnFormatter.java

Coloumn -> Column

Comment by Christopher Zimmermann [ 12/Feb/14 ]

Review:
Action text "Validate" and "Invalidate" are not self explanatory. I suggest standard: "Approve" and "Reject". And the column should be called "Approved".

Comment by Christopher Zimmermann [ 12/Feb/14 ]

When you validate a message - ui shows notification "Message has been activated"
When you invalidate a message - ui shows notificaiton "Message has been deactivated".
This is incorrect.
Message should either refer to validation- or i would suggest to approval:
"Message has been approved"
"Message has been rejected"

Comment by Christopher Zimmermann [ 12/Feb/14 ]

Fix style name:
is: .coloumn-icon
should be .column-icon

Comment by Christopher Zimmermann [ 12/Feb/14 ]

strings:
"thread has been locked" (unlocked)
"forum has been locked" (unlocked)

should be in language property file, not in configuration, so that they can be i18n-ized.

Comment by Christoph Meier [ 12/Feb/14 ]

Added a lot more success- and failure-messages from into language property file (beside those mentioned above).
(and fixed the other things, too.)

Comment by Christopher Zimmermann [ 13/Feb/14 ]

Review:
Rename ValidatedColoumnFormatter.java to ValidatedColumnFormatter.java

Maybe do a search on "coloumn"?

Comment by Christoph Meier [ 17/Feb/14 ]

Note: On master-branch, changes concerning this ticket are committed against MGNLFORUM-193, MGNLFORUM-194 and MGNLFORUM-215

Comment by Roman Kovařík [ 19/Feb/14 ]

QA:

Christopher Zimmermann added a comment - 12/Feb/14 4:48 PM
Review:
Action text "Validate" and "Invalidate" are not self explanatory. I suggest standard: "Approve" and "Reject". And the column should be called "Approved".

The column is still called Validated. If we decided to use name Approved, this should be also reflected in ValidatedColumnFormatter/ValidatedColumnDefinition.

Generated at Mon Feb 12 02:01:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.