[MGNLFORUM-233] Filter "pagecomments" from the forums-list Created: 12/Feb/14  Updated: 14/Feb/14  Resolved: 14/Feb/14

Status: Closed
Project: Forum (closed)
Component/s: client-ui, templates
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Won't Fix Votes: 0
Labels: template
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File forum-list__.png    
Issue Links:
causality
is causing MGNLFORUM-235 Add property "visibility" to forum-node Closed
is causing MGNLFORUM-236 Improve component forum-list Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The overview listing all the forums MUST NOT show the forum called "pagecomments", which is a special case used for the commenting of the pages (of the commenting-module).
(See screenshot)



 Comments   
Comment by Christoph Meier [ 12/Feb/14 ]

Filtering actually is easy done in the template-script (/info/magnolia/module/forum/frontend/forum-list.html) or probabyly better in the model (info.magnolia.module.forum.frontend.action.ForumList).
But it doesn't make sense to filter something from pagecommenting (the module on which forum is NOT dependent, but the otherway round).
=>
Instead, it could be a good idea to make it configurable what forums are filtered, and the commenting-module writes into that configuration on installation.

Comment by Christoph Meier [ 13/Feb/14 ]

So: The forum named "pagecomments" should be filtered in the module forum, which is independent from module-pagecomments. That would be a bit "ugly".

I would propose to allow to add a property or node to the config of the forum on which one can configure what to filter on the forum-list. PageCommenting itself could the write into the config. of forum during installation.

It's probably a bit "over-engineered" but more clean than just to filter hardcoded.

Comment by Magnolia International [ 13/Feb/14 ]

You can't filter solely based on the "pagecomments" name. That name is not fixed, and is different when multi-site and i18n are in play (one commenting forum per site and/or per locale)

Comment by Christoph Meier [ 13/Feb/14 ]

I close this ticket since it cannot fixed properly (see last comment from Greg).
(Furthermore this was never filtered, yet.)

To have it really nice, 2 improvements are imaginable:

  • Add another property to the forum-node, smthng. like "visibility".
  • Improve the forum-list component, in a way, that it might reflect nested forums, forums from diff. locales and or multisites. (Currently it just show children of the root-node of the workspace).
Comment by Christoph Meier [ 13/Feb/14 ]

cannot be fixed properly. See last comments.

Generated at Mon Feb 12 02:01:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.