[MGNLFORUM-233] Filter "pagecomments" from the forums-list Created: 12/Feb/14 Updated: 14/Feb/14 Resolved: 14/Feb/14 |
|
| Status: | Closed |
| Project: | Forum (closed) |
| Component/s: | client-ui, templates |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Christoph Meier |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | template | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
The overview listing all the forums MUST NOT show the forum called "pagecomments", which is a special case used for the commenting of the pages (of the commenting-module). |
| Comments |
| Comment by Christoph Meier [ 12/Feb/14 ] |
|
Filtering actually is easy done in the template-script (/info/magnolia/module/forum/frontend/forum-list.html) or probabyly better in the model (info.magnolia.module.forum.frontend.action.ForumList). |
| Comment by Christoph Meier [ 13/Feb/14 ] |
|
So: The forum named "pagecomments" should be filtered in the module forum, which is independent from module-pagecomments. That would be a bit "ugly". I would propose to allow to add a property or node to the config of the forum on which one can configure what to filter on the forum-list. PageCommenting itself could the write into the config. of forum during installation. It's probably a bit "over-engineered" but more clean than just to filter hardcoded. |
| Comment by Magnolia International [ 13/Feb/14 ] |
|
You can't filter solely based on the "pagecomments" name. That name is not fixed, and is different when multi-site and i18n are in play (one commenting forum per site and/or per locale) |
| Comment by Christoph Meier [ 13/Feb/14 ] |
|
I close this ticket since it cannot fixed properly (see last comment from Greg). To have it really nice, 2 improvements are imaginable:
|
| Comment by Christoph Meier [ 13/Feb/14 ] |
|
cannot be fixed properly. See last comments. |