[MGNLFORUM-66] validation state of messages not taken into account for message counters and last message references Created: 16/Oct/07  Updated: 02/Dec/13  Resolved: 20/Aug/10

Status: Closed
Project: Forum (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 4.0 ? (rewrite)

Type: Bug Priority: Critical
Reporter: Magnolia International Assignee: Fabrizio Giustina
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLFORUM-43 Hide thread if config option showUnva... Closed
is related to MGNLFORUM-25 Show last thread/message (author,time... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

This is a conflict between the resolutions of MGNLFORUM-43 and MGNLFORUM-25

Since MGNLFORUM-25 was resolved by adding a property to the forum nodes, which is updated every time a message is posted, it conflicts with the resolution of MGNLFORUM-43 : if the lastMessage is not validated or even invalidated, the reference to lastMessage on forum is "wrong", since it points to a message which is not visible. Thread count also has the same issue, since it simply counts the number of children (threads), not taking into their being validated.



 Comments   
Comment by Magnolia International [ 23/Jul/09 ]

The lastMessage and firstMessage properties were introduced for ease-of-use reasons. The firstMessage is needed in threads, because it is what mostly defines this thread (in a forum, this is where the discussion is started, where the original question is asked, etc. If you had a blog, the firstMessage could be considered the blog post itself).

In templates, they allow to do stuff like ${forum. lastMessage.author} transparently. We could fake them by having util methods on the ForumManager, or even wrap the nodes, this would just be less elegant and practical.

OTOH, they cause issues (MGNLFORUM-75, MGNLFORUM-62, ...) and this one.

Comment by Fabrizio Giustina [ 20/Aug/10 ]

now the last message is always retrieved properly, the lastMessage reference is not used anymore in forum/thread list

Comment by Christoph Meier [ 02/Dec/13 ]

closed, since it was resolved a long time ago

Generated at Mon Feb 12 02:00:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.