[MGNLGA-17] Remove STK dependency Created: 05/Mar/15  Updated: 28/Jul/15  Resolved: 23/Mar/15

Status: Closed
Project: Magnolia Google Analytics
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3

Type: Task Priority: Neutral
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relation
is related to MGNLDEMO-85 Re-add Google analytics Marketing Tag... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Extract STK functionality

 Description   

Provided dependency. The module uses

  • info.magnolia.module.templatingkit.functions.STKTemplatingFunctions
  • info.magnolia.module.templatingkit.resources.STKResourceModel


 Comments   
Comment by Federico Grilli [ 11/Mar/15 ]

For the release notes/documentation:
starting with version 1.3 (Magnolia 5.4) this module no longer depends on STK, however it'll try to play nicely with it in case it finds it installed. This basically impacts the way resources (the javascripts needed by the module ) are installed.

  • STK is installed:
    • resources are moved under /google-analytics/js
    • folder /templating-kit/js/ga is removed
    • references in /templating-kit/js/mobile-scriptloader-plugin and /templating-kit/js/scriptloader-plugin are updated to the new script location
  • No STK
    • resources are installed under /google-analytics/js
    • resources aren't referenced anywhere and it is the developer's responsibility to ensure jQuery (upon which the module libs depend) is available and to provide in their templates a valid link to the resources themselves, also ensuring they are loaded in the correct order, i.e.. jQuery must be loaded first.
      For example (TO BE VERIFIED) when using the new Site module templating functions (sitefn: ) one could do
      [#list site.jsFiles as jsFile]
          <script src="${jsFile.link}" type="text/javascript"></script>
      [/#list]
      
Comment by Philip Mundt [ 20/Mar/15 ]

Migration needs to be possible. We have to remove precondition and maintain version handling.
Minimum version is 1.1.2.

Comment by Philip Mundt [ 27/Mar/15 ]

I guess your forgot the re-add (some of) the old delta tasks and to remove/adjust the precondition.

Generated at Mon Feb 12 05:50:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.