[MGNLGA-19] Update install tasks for ga resources Created: 14/Jan/16  Updated: 13/Nov/17  Resolved: 14/Jan/16

Status: Closed
Project: Magnolia Google Analytics
Component/s: None
Affects Version/s: 1.3
Fix Version/s: 1.3.1

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: resources
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLSTK-1519 Do not strip resources extension in I... Closed
dependency
depends upon MGNLRES-181 STK theme resources appear twice afte... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Sprint: Saigon 26
Story Points: 2

 Description   

In MGNLSTK-1519, we updated how STK resources are installed:

  • We replaced deprecated tasks with newer InstallTextResourceTask and InstallBinaryResourceTask
  • We don't strip resource extensions anymore
  • We updated those resources as well, thanks to the purposely introduced ResourceCleanUpTask; this includes:
    • resources matching /templating-kit/js/*.swf
    • resources matching /templating-kit/js/*.js
    • InstallSTKResourcesTask#specialResources

Now, because google-analytics module installs its resources inside STK scriptloaders, it means the STK upgrade is taking care of them (cleanup task by JS pattern), while for fresh installs extensions are still stripped.

Worth noting that nothing is broken; just 4 minor migration diffs show up.


Generated at Mon Feb 12 05:50:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.