[MGNLGAV-30] Installation should alert the user to set credentials Created: 08/Jul/16 Updated: 13/Jul/16 Resolved: 13/Jul/16 |
|
| Status: | Closed |
| Project: | Google Analytics Visualization |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Minor |
| Reporter: | Richard Gange | Assignee: | Unassigned |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Date of First Response: | |||||
| Description |
|
It would be a nice improvement if we could alert the user that the configuration credentials must be set in order for the module to start correctly.
When you install the module the first time you will inevitably hit this issue: 2016-07-07 18:37:47,811 INFO info.magnolia.module.ModuleManagerImpl : Initializing module google-analytics 2016-07-07 18:37:47,895 INFO info.magnolia.module.ModuleManagerImpl : Initializing module google-analytics-visualization 2016-07-07 18:37:47,909 INFO info.magnolia.module.ModuleManagerImpl : Starting module google-analytics-visualization 2016-07-07 18:37:47,909 ERROR lia.ga.visualization.GoogleAnalyticsServiceFactory: Can't initialize GoogleCredential. Mandatory fields are missing in google analytics credential config. Please fix your configuration under [config:/modules/google-analytics-visualization/credentialConfig]. 2016-07-07 18:37:47,925 WARN ent.registry.GoogleAnalyticsClientObservingManager: Can't schedule clients because google analytics service isn't initialized properly, please check credential configuration. Unless you bootstrap in the credentials before the module starts, which is unlikely for someone testing out the module. When you try to open the app in crashes because the module was never able to start. The app can't know about the issue that occurred during startup so it crashes with a somewhat generic Guice provision error. So when the module installs it would be helpful to add a message about setting the configuration. |
| Comments |
| Comment by Milan Divilek [ 13/Jul/16 ] |
|
Module itself starts correctly also without configured permissions, log just warn about not properly configured permissions.
This has nothing to do with gav permissions. It's bug in Magnolia UI 5.4.7 - btw. App already warn you about not properly configured permissions. |