[MGNLGQL-105] Get asset link from AssetRendition instead of Asset Created: 30/Aug/21 Updated: 20/Sep/22 |
|
| Status: | Selected |
| Project: | Magnolia GraphQL |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Evzen Fochr | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Sprint: | Cloud Service 17 | ||||||||||||||||
| Story Points: | 3 | ||||||||||||||||
| Description |
|
GraphQL AssetRendition links depend on sites and theme, thus making it impossible to retrieve such links for external asset renditions such as CDN link. It's because rendition config for external assets is not in themes, but it's stored in the dam cloud module. We need to change implementation of the AssetRenditionsDataFetcher to not rely on sites and themes. That will be possible when MGNLDAM-988 is resolved. |
| Comments |
| Comment by Evzen Fochr [ 30/Aug/21 ] |
|
Follow up |
| Comment by Evzen Fochr [ 07/Sep/21 ] |
|
After discussion we will move solution to GraphQL so it will use renderers |
| Comment by Evzen Fochr [ 16/Sep/21 ] |
|
jsimakWhat about using multibinding for AssetRenditionsDataFetcher that would be one per asset provider (from ItemKey) and cloud external-dam-s3-cloud module can bring his own Fetcher. |
| Comment by Jaroslav Simak [ 16/Sep/21 ] |
|
efochr I'll add that to the description, thanks. |