[MGNLGROOVY-123] Keyboard shortcuts interfere with groovy console Created: 29/Sep/14 Updated: 17/Aug/15 Resolved: 16/Oct/14 |
|
| Status: | Closed |
| Project: | Magnolia Groovy Module |
| Component/s: | console |
| Affects Version/s: | 2.3 |
| Fix Version/s: | 2.3.1 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Richard Gange | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Description |
|
The keyboard shortcuts create a undesirable user experience when using the groovy console. For example, typing a 3 activates this favorites. |
| Comments |
| Comment by Christopher Zimmermann [ 16/Oct/14 ] |
|
In MagnoliaShellViewImpl, because terminal is a special case, I think it would be more clear if you left the test for textarea/field/select as it was... if ("input".equalsIgnoreCase(tagName) || "select".equalsIgnoreCase(tagName) || "textarea".equalsIgnoreCase(tagName)) { And then add an additional test for the terminal - and put the comment just above that test. |
| Comment by Zak Greant [ 14/Aug/15 ] |
|
Perhaps we have a regression? Using the groovy console in 5.4, I am experiencing the same issues. eg. 1 opens the App Launcher, 2 the Pulse, etc. |
| Comment by Richard Gange [ 14/Aug/15 ] |
|
zgreant I tried it on the demo site and did not experience that issue. Maybe it's browser related? |
| Comment by Zak Greant [ 14/Aug/15 ] |
|
Interesting. I don't have the issue in the demo, but I do have the issue in a custom 5.4 bundle. Both the demo and the custom bundle are running v2.4.0 of the Groovy module. Perhaps something didn't get bootstrapped or the fix is in another module? |
| Comment by Federico Grilli [ 14/Aug/15 ] |
|
The fix involves both UI and groovy module. Both were released with Magnolia 5.3.5 so that's odd indeed. |
| Comment by Zak Greant [ 14/Aug/15 ] |
|
I can reproduce this on the demo now. 1. Open Dev Tools > Groovy > Groovy Console |
| Comment by Federico Grilli [ 17/Aug/15 ] |
|
Indeed I can now reproduce it. This is definitely a regression, see related ticket. |
| Comment by Zak Greant [ 17/Aug/15 ] |
|
Thanks for looking into it again! |