[MGNLGROOVY-125] Fix create/edit script quirks Created: 13/Oct/14  Updated: 31/Oct/14  Resolved: 27/Oct/14

Status: Closed
Project: Magnolia Groovy Module
Component/s: tree/dialog
Affects Version/s: None
Fix Version/s: 2.3.1

Type: Bug Priority: Major
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
depends upon MGNLUI-3212 BasicTextCodeField validation kicks i... Closed
relation
is related to MGNLGROOVY-121 Usability issues Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Use a proper validator instead of throwing an ActionExecutionException. This will

  • enable the user to fix the script on the fly rather than to have to close it and reopen it now due to the save button being no longer available
  • move validation logic to a more proper place
  • name/rename a class correctly out-of-the-box without having first to open it and rename it (this will work only when using the dialog not the rename action [different story there])


 Comments   
Comment by Christopher Zimmermann [ 21/Oct/14 ]

Problem with validation:
If you hit save and there is a problem in the code you get a validation error. So far so good.
But then as you change the code, additional validation errors kept getting added to the error box - so that the whole history of validation errors remain visible!

Probably this live update of validation errors should be removed - at least it should only show the actual current errors.
And if the live update is removed - also when you hit save - if there are still validation errors - only the active validation errors should be displayed.

Comment by Federico Grilli [ 22/Oct/14 ]

Couldn't solve the validation error within the module itself as it is a more generic ui field issue. See related jira ticket.

Comment by Christopher Zimmermann [ 22/Oct/14 ]

Even if the error is not in Groovy module. I dont think we can push this fix without the fix on the linked UI ticket.
See attached image on http://jira.magnolia-cms.com/browse/MGNLUI-3212

Comment by Federico Grilli [ 27/Oct/14 ]

In spite of the validation glitch I think the benefits of the fixes made here overweigh it.

Generated at Mon Feb 12 05:55:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.