[MGNLGROOVY-129] Groovy script editor subapp should be wide by default Created: 23/Oct/14 Updated: 19/Apr/23 Resolved: 04/Apr/23 |
|
| Status: | Closed |
| Project: | Magnolia Groovy Module |
| Component/s: | None |
| Affects Version/s: | 3.0.1 |
| Fix Version/s: | 4.0.0, 3.0.5 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Dai Ha |
| Resolution: | Fixed | Votes: | 7 |
| Labels: | quickwin | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 3.5h | Time Spent: | 3.5h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Attachments: |
|
||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||
| Epic Link: | DevX Bucket | ||||||||||||||||||||||||||||||
| Sprint: | DevX 34 | ||||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||||||||
| Work Started: | |||||||||||||||||||||||||||||||
| Approved: |
Yes
|
||||||||||||||||||||||||||||||
| Description |
|
Code editing is more comfortable in a wide dialog. I thank ethebti form their contribution in the comments, but I don't think that changing the css is necessary - Im 90% sure there is a configuration to make it open wide. See "wide" on this page: https://docs.magnolia-cms.com/product-docs/6.2/Developing/Templating/Dialog-definition.html#_dialog_properties
|
| Comments |
| Comment by Ezzeddine Thebti [ 08/Sep/21 ] |
|
Same remark for Magnolia version 6.2.18 |
| Comment by Ezzeddine Thebti [ 10/Jan/23 ] |
|
Hi,
.v-slot-textcodefield {
width: 1000px;
}
in files : expandingtextarea.css & expandingtextarea.css.gz
It worked with versions 6.2.18 and 6.2.27 !
Regards. Ezzeddine |
| Comment by Christopher Zimmermann [ 05/Apr/23 ] |
|
I see that we expanded the width to ```max-width: 1000px;``` I was wondering why we dont expand it further.. is a max-width needed or could it just be width:100% so that the developer can use all the space they want. Or could max-width property be removed? (overwritten with nothing) |
| Comment by Dai Ha [ 11/Apr/23 ] |
|
Currently the width value is 100%, we set the max-width value due to the look-n-feel reason (iirc) because the value here will effect the whole panel so it will make other field's width expands together. And other reason is: as developer we normally won't use all of editor width for coding (the most common convention is about 120 columns) to ensure code readability. |