[MGNLGROOVY-129] Groovy script editor subapp should be wide by default Created: 23/Oct/14  Updated: 19/Apr/23  Resolved: 04/Apr/23

Status: Closed
Project: Magnolia Groovy Module
Component/s: None
Affects Version/s: 3.0.1
Fix Version/s: 4.0.0, 3.0.5

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Dai Ha
Resolution: Fixed Votes: 7
Labels: quickwin
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 3.5h Time Spent: 3.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File debug-css-files.PNG     PNG File magnolia-vaadin-widgetset-pro-module.PNG    
Issue Links:
relation
is related to MGNLUI-2267 Dialog can be toggled "wide" with but... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLGROOVY-243 Implement Sub-task Completed Dai Ha  
MGNLGROOVY-244 Review Sub-task Completed Jaroslav Simak  
MGNLGROOVY-245 piQA Sub-task Completed Oanh Thai Hoang  
MGNLGROOVY-246 QA Sub-task Completed Jaroslav Simak  
MGNLGROOVY-247 QA 6.2 Sub-task Completed Jaroslav Simak  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Epic Link: DevX Bucket
Sprint: DevX 34
Story Points: 2
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

Code editing is more comfortable in a wide dialog.
Easily accomplished with a configuration value, see linked ticket. https://jira.magnolia-cms.com/browse/MGNLUI-2267

I thank ethebti form their contribution in the comments, but I don't think that changing the css is necessary - Im 90% sure there is a configuration to make it open wide.

See "wide" on this page: https://docs.magnolia-cms.com/product-docs/6.2/Developing/Templating/Dialog-definition.html#_dialog_properties

 



 Comments   
Comment by Ezzeddine Thebti [ 08/Sep/21 ]

Same remark for Magnolia version 6.2.18

Comment by Ezzeddine Thebti [ 10/Jan/23 ]

Hi,
I tried to modify Magnolia magnolia-vaadin-widgetset-pro and added this CSS class

 

.v-slot-textcodefield {
    width: 1000px;
}

in files : expandingtextarea.css & expandingtextarea.css.gz

 

It worked with versions 6.2.18 and 6.2.27 !

 

Regards.

Ezzeddine

Comment by Christopher Zimmermann [ 05/Apr/23 ]

I see that we expanded the width to 

```max-width: 1000px;```

I was wondering why we dont expand it further.. is a max-width needed or could it just be width:100% so that the developer can use all the space they want.

Or could max-width property be removed? (overwritten with nothing)

Comment by Dai Ha [ 11/Apr/23 ]

Currently the width value is 100%, we set the max-width value due to the look-n-feel reason (iirc) because the value here will effect the whole panel so it will make other field's width expands together. And other reason is: as developer we normally won't use all of editor width for coding (the most common convention is about 120 columns) to ensure code readability.

Generated at Mon Feb 12 05:55:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.