[MGNLGROOVY-153] ScriptDonePollListener stays around after script is done Created: 20/Oct/16  Updated: 05/Dec/16  Resolved: 16/Nov/16

Status: Closed
Project: Magnolia Groovy Module
Component/s: None
Affects Version/s: 2.4.6, 2.5
Fix Version/s: 2.4.7, 2.5.1

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File script-done-poll-listener.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Sprint: Basel 70
Story Points: 2

 Description   

Maybe sort of corner case, still I'd like to report it and fix it (should be easy)
To reproduce it:

  • execute a "long-running" groovy script (anything which takes more than 200ms )
    • the script will send a notification and a message to pulse when done
  • now try to upload a big file in Assets
  • cancel the upload before it's done
  • the groovy script done notify and message appear out of the blue

The reason should lie in the fact that we remove instances of ScriptDonePollListener from the current UI each time we run MgnlGroovyConsole#runAsync and not when the script is done at MgnlGroovyConsole.ScriptDonePollListener#poll.

Vaadin's PollListener s apparently react to any polling event, no matter which component registered it.


Generated at Mon Feb 12 05:56:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.