[MGNLGROOVY-36] Groovy rescue servlet does not work when config:/server is gone Created: 23/Feb/11  Updated: 16/Aug/11  Resolved: 16/Aug/11

Status: Closed
Project: Magnolia Groovy Module
Component/s: console
Affects Version/s: 1.1.1
Fix Version/s: 1.1.2

Type: Bug Priority: Critical
Reporter: Magnolia International Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen shot 2011-02-23 at 14.33.45.png    
Issue Links:
dependency
depends upon MAGNOLIA-3561 RescueSecuritySupport is incomplete Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

After installation as per http://documentation.magnolia-cms.com/modules/groovy.html#RegistertheGroovyRescueServlet, no matter what command is typed, one gets the response html printed in the console. (see screenshot)

To reproduce this, delete or rename config:/server, configure the rescue servlet, and restart.

Using RescueSecuritySupport (for instance by setting the info.magnolia.cms.security.SecuritySupport=info.magnolia.cms.security.RescueSecuritySupport property) could help, if it wasn't for MAGNOLIA-3561.

To fix this issue, the rescue servlet could set this property or component itself, so users don't have to modify their properties.



 Comments   
Comment by Philipp Bärfuss [ 08/Mar/11 ]

Increasing priority as this is essential for supporting the rescue of damaged instance.

Comment by Jan Haderka [ 15/Aug/11 ]

Port to trunk is missing. Also there should be a basic test.

Comment by Federico Grilli [ 15/Aug/11 ]

This issue depends for its core features on MAGNOLIA-3561 which has tests and was ported to trunk. Specific tests for the servlet itself (basically asserting that when Magnolia starts with this particular config, security manager is set as rescue security manager) would be nice but are very hard to set up in a unit test (unless I miss something, they look more like integration tests). I'm afraid that for the time being we should live with manual tests

Comment by Federico Grilli [ 16/Aug/11 ]

reopening for writing missing unit test

Comment by Federico Grilli [ 16/Aug/11 ]

Shame on me, writing a test verifying that state was indeed dead easy.

Generated at Mon Feb 12 05:54:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.