[MGNLGROOVY-51] Install/Update task to execute a Groovy script Created: 28/Sep/11  Updated: 24/Jun/13  Resolved: 24/Jun/13

Status: Closed
Project: Magnolia Groovy Module
Component/s: integration
Affects Version/s: 2.0
Fix Version/s: 2.0.1

Type: New Feature Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Creation of a ExecuteGroovyFileTask that extends AbstractTask. This Task takes a Groovy file name as input parameter, and execute it agains the MgnlGroovyConsole.



 Comments   
Comment by Eric Hechinger [ 28/Sep/11 ]

Related Scrum Task

Comment by Eric Hechinger [ 28/Sep/11 ]

Task and testcases created and commited

Comment by Magnolia International [ 07/Oct/11 ]

A few remarks from my side:

  • make any constructor-initialized field final - shows that it's immutable.
  • the console field seems superfluous. Pass it to the executeScript method, or just initialize it in the method itself.
  • try to throw and catch more specific exceptions if possible. If the using Exception is unavoidable, I'd recommend a little inline comment to explain why that is to developers reading that code later.
Generated at Mon Feb 12 05:55:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.