[MGNLGS-128] Export action extends export from admincentral for no reason Created: 07/Dec/16  Updated: 16/Dec/16  Resolved: 15/Dec/16

Status: Closed
Project: Google Sitemap (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 2.4.1

Type: Bug Priority: Neutral
Reporter: Maxime Michel Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2016-12-07 at 15.34.36.png     PNG File Screen Shot 2016-12-07 at 15.35.00.png    
Template:
Acceptance criteria:
Empty
Date of First Response:
Epic Link: Definitions app problems
Sprint: Kromeriz 74
Story Points: 3

 Description   

Action + extends

/subApps/browser/actions/export extends /modules/ui-admincentral/apps/configuration/subApps/browser/actions/export. However, as the screenshots show, we should not do this if, out of three properties, we override one and don't need another (e.g. command) (additionally info.magnolia.module.googlesitemap.app.actions.ExportSiteMapToXMLActionDefinition doesn't extend info.magnolia.ui.api.action.CommandActionDefinition, the source of the actual problem).

app: siteMaps
from jcr
at /modules/google-sitemap/apps/siteMaps
Source data processing problem: Property [command] not found in class [info.magnolia.module.googlesitemap.app.actions.ExportSiteMapToXMLActionDefinition], property is not assigned: /subApps/browser/actions/export

See: /modules/google-sitemap/apps/siteMaps/subApps/browser/actions/export@extends

Action – unknown property

app: siteMaps
from jcr
at /modules/google-sitemap/apps/siteMaps
Source data processing problem: Property [nodeType] not found in class [info.magnolia.ui.framework.action.OpenEditDialogActionDefinition], property is not assigned: /subApps/browser/actions/editSiteMap

See: /modules/google-sitemap/apps/siteMaps/subApps/browser/actions/editSiteMap@nodeType

Dialog field – unknown property + node name

Also these old properties can go:

dialog: google-sitemap:components/content/siteComponentTab
from jcr
at /modules/google-sitemap/dialogs/components/content/siteComponentTab
Source data processing problem: Property [chooseOnClick] not found in class [info.magnolia.ui.form.field.definition.MultiValueFieldDefinition], property is not assigned: /form/tabs/tabSites/fields/mgnl:googleSiteMapPages

Apart from removing the stray property chooseOnClick we should also rename node to mgnl-googleSiteMapPages (notice the dash vs. colon) and add property name=mgnl:googleSiteMapPages.

See: /modules/google-sitemap/dialogs/components/content/siteComponentTab/form/tabs/tabSites/fields/mgnl:googleSiteMapPages


Generated at Mon Feb 12 02:06:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.