[MGNLGS-2] Google Sitemap does not work on Magnolia 4.3.x Created: 16/Nov/10  Updated: 18/Nov/10  Resolved: 17/Nov/10

Status: Closed
Project: Google Sitemap (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.1

Type: Bug Priority: Blocker
Reporter: Antti Hietala Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

magnolia-module-google-sitemap-1.0.14, Magnolia 4.3.1, Magnolia 4.3.8


Attachments: Text File google-sitemap-error-log.txt    
Issue Links:
relation
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Update Google Sitemap module to work with Magnolia 4.3.x. MGNLGS-1 provided a fix for URL shortening compatibility but only a snapshot release was provided. No public release of this module exists for m4.3.x.

Issue manifests itself when sitemap fails to render on public instance. To reproduce:

  1. Install Magnolia Enterprise 4.3.8
  2. Install magnolia-module-google-sitemap-1.0.14
  3. Activate page /google-sitemap
  4. Request the page on public instance, http://localhost:8080/google-sitemap.html
  5. System does not render the page.

Error logged:

2010-11-16 11:47:16,878 ERROR ase.[Catalina].[localhost].[/magnoliaPublic].[jsp]: 
Servlet.service() for servlet jsp threw exception java.lang.NullPointerException
  at ch.esense.magnolia.module.googlesitemap.tags.SitemapTag.drawChildren(SitemapTag.java:418)
...
2010-11-16 11:47:16,881 ERROR info.magnolia.module.templating.RenderingFilter   : 
Can't render template /templates/google-sitemap/default.jsp 
info.magnolia.module.templating.RenderException:  
Can't render template /templates/google-sitemap/default.jsp
  at info.magnolia.module.templating.renderers.JspTemplateRenderer.onRender(JspTemplateRenderer.java:76)

Full error message attached.

Tested module-google-sitemap-1.0.14 on Magnolia 4.3.1 and Magnolia 4.3.8.



 Comments   
Comment by Zdenek Skodik [ 16/Nov/10 ]

btw there is still used deprecated path property instead of templatePath.

Comment by Jan Haderka [ 16/Nov/10 ]

Happens when there is a content that doesn't have last modification date (MetaData.getModificationDate() can return null).

Comment by Federico Grilli [ 17/Nov/10 ]

This was implicitly solved by http://jira.magnolia-cms.com/browse/MGNLGS-1

Comment by Christian Ringele [ 18/Nov/10 ]

Changes of MGNLGS-1 (implicit solution) looked fine.

Generated at Mon Feb 12 02:05:29 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.