[MGNLGS-71] Review the new mobile support Created: 02/Jan/14  Updated: 28/Feb/14  Resolved: 28/Feb/14

Status: Closed
Project: Google Sitemap (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.4

Type: Task Priority: Major
Reporter: Zdenek Skodik Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLGS-18 Mobile sitemap support Closed
dependency
relation
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Just a quick look exposes few quirks/leftovers, i.e.:

  • the page template definition uses a sitemapType property of no use (default renderable definition, null value)
  • from an UX perspective it might be good to give the radio control for switching between desktop/mobile variations at least some title (and/or description)
  • missing values for i18n keys like dialog.pages.googleSitemapProperties.
  • missing update task


 Comments   
Comment by Christoph Meier [ 27/Feb/14 ]

review:
Please add a test for GoogleSiteMapVersionHandler and test the latest update.

Comment by Roman Kovařík [ 27/Feb/14 ]

Migration tests results:
http://hudson.magnolia-cms.com/view/Migration/job/m_4-5-migration_1.2.x-branch_with_integration_tests/ws/magnolia-migration-integration/diff-reports/config.modules.google-sitemap.html
http://hudson.magnolia-cms.com/view/Migration/job/m_4-5-migration_1.2.x-branch_with_integration_tests/ws/magnolia-migration-integration/diff-reports/website.html

Comment by Milan Divilek [ 27/Feb/14 ]

Reopen: GS dialog shows "dialog.pages.googleSitemapProperties.sitemapType.label" and "dialog.pages.googleSitemapProperties.sitemapType.description"keys instead of values.

Generated at Mon Feb 12 02:06:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.