[MGNLHOOK-145] End to end tests for webhooks on SaaS Created: 20/Jun/22 Updated: 16/Nov/22 Resolved: 16/Nov/22 |
|
| Status: | Closed |
| Project: | Magnolia Webhooks |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 2.0.1 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Javier Benito | Assignee: | Chuong Doan Huy |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | TPR-E2E | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 5d 1h | Time Spent: | 5d 1h |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Webhooks Maintenance (Phase 1) | |||||||||||||||||||||||||
| Sprint: | DevX 23 | |||||||||||||||||||||||||
| Story Points: | 5 | |||||||||||||||||||||||||
| Description |
|
These scenarios should be implemented : |
| Comments |
| Comment by Christopher Zimmermann [ 03/Nov/22 ] |
|
To save time, and since JCR will soon be discontinued on SaaS - I think we can skip the JCR tests. |
| Comment by Christopher Zimmermann [ 03/Nov/22 ] |
|
They look good. I think you can go ahead. Just one question: I wonder if we need to test these: + Multiple environments :
jbenito are webhook definitions very different to other definitions - do you think its worth testing the above - or would that just be redundant with other tests.of the environment switching we will do? |
| Comment by Javier Benito [ 04/Nov/22 ] |
|
Sorry I didn't see this yesterday. I've just discussed it with chuong.doan and told him that, if I'm not wrong, environment switch listeners should be configured in any different module (Webhooks, Content Types, etc), so if it works for a given module, it still can fail for a different one. In the case of Webhooks, this piece of code takes care about that, so if somebody removes it, webhooks won't take care about environment definition changes, and will remain the same for all environments, no matter if they have trigger events configured or not. |
| Comment by Javier Benito [ 04/Nov/22 ] |
|
Adding more detail / new discoveries about this, currently:
So I'd say that taking also this into account, I feel that we need a test for environment switching on webhooks, because now on SaaS environment switch is working fine for Content Types for instance, but not for Webhooks. |