Demonstration project: Netlify and Vercel (MGNLHOOK-36)

[MGNLHOOK-346] QA Created: 04/Apr/23  Updated: 17/Apr/23  Resolved: 17/Apr/23

Status: Completed
Project: Magnolia Webhooks
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Sub-task Priority: Neutral
Reporter: Phong Le Quoc Assignee: Javier Benito
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Team: DeveloperX
Date of First Response:
Sprint: DevX 34, DevX 35

 Comments   
Comment by Javier Benito [ 12/Apr/23 ]

Just some comments I've seen during QA:

  • I believe Webhooks are still an Enterprise Module so they work on Dx Core, not on the Community version. So I think we need to update the documentation to use magnolia-dx-core-webapp instead magnolia-community-webapp.
  • I've needed to create a free account in ngrok webpage to make it work, as I was getting an ERR_NGROK_6022. So maybe we could add a warning or similar, to the user, for them to know that maybe they need to Sign Up, as we're already doing for example for Netlify or Vercel?
  • Link to https://docs.magnolia-cms.com/saas/hello-saas/netlify.html is hidden under a user/password, and now is being exposed through Magnolia Docs, so I don't know if this is correct.
  • By the way, those steps related to Netlify configuration are outdated (https://docs.magnolia-cms.com/saas/hello-saas/netlify.html , cc mdrapela). The way to configure Netlify has changed.
  • What about including info related to configuring light-modules in Magnolia or is it something that anybody taking a look at this demo project, should know? 

I've managed to make it work in Vercel, but not in Netlify. I'll try it again tomorrow, I'd say it's something related to Netlify, but I want to be sure.

Comment by Javier Benito [ 13/Apr/23 ]

I've tested it again with Netlify and it works as expected.

Now we just need to discuss/address my previous comments plequoc 

Comment by Christopher Zimmermann [ 13/Apr/23 ]

THanks - agree with all your comments accept for "including info related to configuring light-modules". Doesnt need to be a part of this tutorial.

SaaS docs should not be linked to at all.

Generated at Mon Feb 12 10:03:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.