[MGNLIMG-121] Upgrade to Guava 16 Created: 25/Feb/14 Updated: 09/Apr/14 Resolved: 09/Apr/14 |
|
| Status: | Closed |
| Project: | Imaging |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 3.1 |
| Type: | Task | Priority: | Blocker |
| Reporter: | Magnolia International | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Epic Link: | DAM / CMIS | ||||||||||||||||||||||||
| Sprint: | 5.3 Sprint 4, 5.3 Sprint 5 | ||||||||||||||||||||||||
| Description |
|
Magnolia 5.3 will be shipped with Guava 16. Unfortunately, this means CachingImageStreamer has to be adapted. Details: That's because caching functionality in MapMaker was move to CacheBuilder. |
| Comments |
| Comment by Magnolia International [ 13/Mar/14 ] |
|
I just read through the MapMaker migration guide, and I'm not sure this evolved for the better, for our very specific case. Our usage of MapMaker is for "current jobs", ie. keeping tracks of various image generation jobs running in parallel. Once the job is done, the job stays in the map for 500ms, but the image isn't regenerated. Further requests don't even go through this map. It looks like what we really needed was simply the ConcurrentMap, and maybe we took a shortcut by using a Computing version of it. Sequence diagrams and some clever decoupling and renaming might help. |
| Comment by Christopher Zimmermann [ 17/Mar/14 ] |
|
In order to upgrade to Guava 16, the usage of MapMaker has been replaced with CacheBuilder, as MapMaker is deprecated. |
| Comment by Christopher Zimmermann [ 18/Mar/14 ] |
|
Pushed to master in two commits, one for actual changes, one for upping version to 3.1-SNAPSHOT. |
| Comment by Milan Divilek [ 08/Apr/14 ] |
|
Imaging has dependency to magnolia main 5.0.2, but this version use guava 10.0.1, which is not compatible with guava 16.0.1. |
| Comment by Christopher Zimmermann [ 09/Apr/14 ] |
|
Closing again. Ive linked the existing ticket for the problem that Milan has mentioned. |