[MGNLIMG-128] Verify whether module descriptor dependency on activation is necessary Created: 02/Apr/14  Updated: 02/Oct/23  Resolved: 02/Oct/23

Status: Closed
Project: Imaging
Component/s: None
Affects Version/s: 3.1
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MAGNOLIA-6982 NPE when workspace subscription setup... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Greg writes:

imaging module's module descriptor has a dep on activation, although i don't see that dep in pom files, and i can't seem to think why it'd be needed either - could verify it's indeed not needed at all and remove it ?



 Comments   
Comment by Mikaël Geljić [ 13/Mar/17 ]

Dep is there only because any module declaring a workspace "requires" activation.

SetupModuleRepositoriesTask (via default MVH) fails to get an ActivationManager instance, then blows with NPE.
I'm proposing a patch in core, to log a warning to install context/screen instead:

Skipping subscription setup for workspace imaging, activation module is not installed.

Meanwhile, I see no reason either, why not removing the dep from module descriptor, even straight away. Either way, without my patch Magnolia won't start or install properly.

Comment by Laura Delnevo [ 02/Oct/23 ]

Hello,
This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you.
Thank you,
The Magnolia Team

Generated at Mon Feb 12 02:12:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.