[MGNLIMG-173] Remove now-redundant validateFileExtension feature Created: 25/Sep/15  Updated: 09/Feb/17  Resolved: 11/May/16

Status: Closed
Project: Imaging
Component/s: None
Affects Version/s: None
Fix Version/s: 3.3

Type: Improvement Priority: Neutral
Reporter: Robert Šiška Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1h
Original Estimate: Not Specified

Issue Links:
supersession
supersedes MAGNOLIA-6372 Set correct content type of rendered ... Closed
supersedes MGNLIMG-115 Images are displayed regardless of it... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Sprint: Kromeriz 43
Story Points: 1

 Description   

Remove validateFileExtension from /server/filters/servlets/ImagingServlet. Same effect can be achieved by setting validateContentType & registeredExtensionsOnly in /server/filters/contentType.

Since MAGNOLIA-6348 this feature is implemented in a filter for all requests. The feature in Imaging is redundant and can be removed. Removing it will facilitate refactorings as proposed in MGNLIMG-150.



 Comments   
Comment by Magnolia International [ 28/Sep/15 ]

rsiska, I had already opened MGNLIMG-172
Reopening: I don't see why we backport this and create more maintenance/documentation work for ourselves with this.

  • Remove the feature only on master, for the next major release.
  • Remove the test altogether (it's completely pointless)
  • Need to upgrade dependencies so it strictly depends on 5.4.3+
  • Missing link to MGNLIMG-115
Comment by Robert Šiška [ 08/Oct/15 ]

Fixed on feature/MGNLIMG-173-remove-extension-check branch.

Comment by Evzen Fochr [ 08/Oct/15 ]

Do not move to next sprint. It will be integrated into new major version of imaging.

Comment by Robert Šiška [ 09/May/16 ]

For release notes: validateFileExtension was removed in 3.3. Same effect can be achieved by setting validateContentType & registeredExtensionsOnly in ContentTypeFilter.

Generated at Mon Feb 12 02:13:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.