[MGNLIMG-201] Concurrent image generation jobs generate more images than necessary Created: 11/Sep/17  Updated: 25/May/23

Status: Accepted
Project: Imaging
Component/s: None
Affects Version/s: 3.3.1
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLIMG-137 BinaryNodeParameterProviderFactory do... Closed
is related to MGNLIMG-200 Remove uses of the Content API Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: AuthorX Maintenance
Story Points: 3

 Description   

Removing the Content API from the Imaging module (MGNLIMG-200) revealed an issue with the generation of uncached images in the following test info.magnolia.imaging.caching.CachingImageStreamerRepositoryTest#testRequestForSimilarUncachedImageOnlyGeneratesItOnce.

ContentParameterProviderFactory used to wrap Content with a SimpleEqualityContentWrapper providing equals and hashCode methods which would eventually allow storing them by CacheBuilder (see c-tor of CachingImageStreamer). Such wrapper does not exist for Node, hence using e.g. BinaryNodeIdentifierParameterProviderFactory would cause the generated images to be never cached locally thus generating and saving the same image multiple times.



 Comments   
Comment by Antti Hietala [ 06/Apr/18 ]

fgrilli, does "images to be never cached locally" mean in browser or in server? Could you add a sentence to the description how the user perceives this problem? Are thumbnails generated twice for instance?

Generated at Mon Feb 12 02:13:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.