[MGNLIMG-239] ImagingServlet is not handling non io exceptions Created: 14/Feb/22  Updated: 25/Aug/23  Resolved: 03/Aug/23

Status: Closed
Project: Imaging
Component/s: None
Affects Version/s: 3.5.2
Fix Version/s: 4.0.0, 3.5.9

Type: Bug Priority: Major
Reporter: Björn Eschle Assignee: Anh Vu
Resolution: Fixed Votes: 0
Labels: quickwin
Σ Remaining Estimate: 0d Remaining Estimate: 0d
Σ Time Spent: 5d 2.5h Time Spent: 5d 0.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLIMG-318 Implement Sub-task Closed Anh Vu  
MGNLIMG-319 Review Sub-task Closed Dai Ha  
MGNLIMG-320 piQA Sub-task Closed Javier Benito  
MGNLIMG-321 QA Sub-task Closed Oanh Thai Hoang  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: Support
Sprint: DevX 42, DevX 43
Story Points: 2
Team: DeveloperX
Work Started:
Approved:
Yes

 Description   

Steps to reproduce

  1. Throw any exception other than IllegalArgumentException, ImagingRuntimeException, ImagingException, IOException
    • E.g. Use invalid file ending like ".Jpg" (capital "J" lowercase "pg"), will throw IllegalStateException("Can't find ImageWriter for Jpg")

Expected results

Exception is logged and an error response is returned.

Actual results

Exception is not logged nor is any response returned.

Workaround

Development notes

Simple catching Exception instead of IOException should fix it:

https://git.magnolia-cms.com/projects/MODULES/repos/imaging/browse/magnolia-imaging/src/main/java/info/magnolia/imaging/ImagingServlet.java#92



 Comments   
Comment by Jens Koolwaay [ 17/Jun/22 ]

I want to raise the awareness for this ticket. We have editosr who are repeadily using the jpg-File endings with capital letters and then cannot see their picture and do not understand why. It would be helpful if the ending of the format would be corrected while uploading if capital letters are involved. Thank you in advance.

Comment by Björn Eschle [ 20/Mar/23 ]

any updates? Current magnolia version (6.2.29 with imaging 3.5.6) still has this issue.

Comment by Richard Gange [ 25/Aug/23 ]

Hello beschle-

6.2.38 was released today.

Cheers
Rich

Generated at Mon Feb 12 02:13:38 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.