[MGNLIMG-50] Concurrency issues / review Created: 26/May/09 Updated: 04/Nov/15 Resolved: 04/Nov/15 |
|
| Status: | Closed |
| Project: | Imaging |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoR: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
There is a knot to untie related to concurrency: the ImagingServlet currently instanciates a new CachingImageStreamer for every request. This also means a different instance of the HierarchyManager (although potentially using the same jcr session, to be checked) The currentJobs map of CachingImageStreamer, which is used to lock and avoid multiple requests for the same generation job is thus also a different instance (it is not static). I can't easily demonstrate the potential issue (if any) with the image gallery of stk, but I suspect that it might useless as it is. If this can be confirmed, we might need to make that map static, or use the same CachingImageStreamer instance (both cases would imply API changes at the ParameterProviderFactory level) Another thing to consider:
|
| Comments |
| Comment by Christopher Zimmermann [ 09/Dec/13 ] |
|
This issue is still valid as of Dec 6, 2013 according to gjoseph. |
| Comment by Magnolia International [ 13/Mar/14 ] |
|
http://www.cs.umd.edu/projects/PL/multithreadedtc/overview.html might be useful, although the library development isn't active, it still seems to be "the" reference. (our current concurrency tests have all sort of multi-threading and synchronization code in the tests themselves, which make them 1) unreadable 2) unmaintainable 3) unreliable http://code.google.com/p/multithreadedtc/ Also read http://jmock.org/threading-executor.html and neighboring pages. |
| Comment by Michael Mühlebach [ 04/Nov/15 ] |
|
Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes. |