[MGNLIMG-87] Figure out if backport from 2.0 branch is needed Created: 07/Nov/11  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Imaging
Component/s: cache
Affects Version/s: None
Fix Version/s: 2.1

Type: Task Priority: Major
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

When diffing the 2.0.6 tag (latest from 2.0 series) against the 2.0 branch, the only non-test related changes are in the following two files:

  • magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/AbstractContentBasedCachingStrategy.java
  • magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/CachingImageStreamer.java

The changes in AbstractContentBasedCachingStrategy.java seem to have been kept intact in the current trunk, but the case of CachingImageStreamer.java isn't as clear:

Between 2.0.6 and 2.0 branch:

svn diff -x -w http://svn.magnolia-cms.com/svn/enterprise/imaging/tags/magnolia-imaging-2.0.6/magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/CachingImageStreamer.java http://svn.magnolia-cms.com/svn/enterprise/imaging/branches/magnolia-module-imaging-2.0/magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/CachingImageStreamer.java

Between 2.0 branch and trunk:

svn diff -x -w http://svn.magnolia-cms.com/svn/enterprise/imaging/branches/magnolia-module-imaging-2.0/magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/CachingImageStreamer.java http://svn.magnolia-cms.com/svn/enterprise/imaging/trunk/magnolia-module-imaging/src/main/java/info/magnolia/imaging/caching/CachingImageStreamer.java

It looks like those changes were done for MGNLIMG-73.

If they are indeed completely ported to trunk/2.2, I would suggest remove the 2.0 branch altogether, as it seems the fixes are not complete on the 2.0 branch ?



 Comments   
Comment by Magnolia International [ 06/Dec/13 ]

Ok, I double checked, and this change indeed exists also in the 2.1.x, 2.2.x and master branches.

Another check between 2.0.6 and 2.0.x shows that all commits done after 2.0.6 have been ported to other branches (copyright years and fixes for MGNLIMG-73). However, since MGNLIMG-73 is not marked as fixed for 2.0.[7x], I'd suggest removing the version from Jira AND the branch from Git.

Comment by Christopher Zimmermann [ 09/Dec/13 ]

Removed version 2.0.7 from Jira.
Removed origin/magnolia-module-imaging-2.0.x from git.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 02:12:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.