[MGNLINTEMPL-18] TemplatesInstallTask should disable installed templates Created: 23/May/11  Updated: 04/Nov/15  Resolved: 04/Nov/15

Status: Closed
Project: Magnolia In-place templating Module (closed)
Component/s: updates
Affects Version/s: 1.2.1
Fix Version/s: Ideas

Type: Bug Priority: Major
Reporter: Felix Rabe Assignee: Unassigned
Resolution: Won't Do Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File 0001-Disable-enabled-templates.patch    
Issue Links:
relation
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

When templates are installed, they should be disabled as well.



 Comments   
Comment by Philipp Bärfuss [ 24/May/11 ]

Not so sure, why should we disable a template which a user willingly enabled?

Comment by Felix Rabe [ 24/May/11 ]

Because when a template (FTL) gets installed, that means the user modifications will be overwritten in JCR anyway. Thus the (still enabled but overwritten) template in JCR is the same as the one in the Jar.

I'm using the patch now in WEBSITE - see r45413.

Comment by Felix Rabe [ 31/May/11 ]

In other words - the user willingly enabled a template to do a quick fix. Once it gets re-installed from the resources, that either means:

  1. The quick fix found its way "upstream".
  2. The quick fix got overlooked and removed by the re-installation.

In either case, the template ends up being the same as the resources, and setting "enabled" to false also helps the user to see that it is not a custom version anymore, but the same as the resources version.

Another aspect is that the acceptResource method returns the value of the "autoImport" property. This means that the user is OK with the template being overwritten in the first place.

Now I want to ask you back - given that "enabled" and "autoImport" are both true, and a given template is to be replaced by the task - under what circumstance would it make sense for the "enabled" property to remain true after the template has been replaced?

Comment by Christopher Zimmermann [ 02/Dec/13 ]

First confirm what the current behaviour is.
Then confirm what we really want.
I agree with Felix that it is confusing if a new template has overridden a customized template - you might want the enabled flag turned off - just so you know you are not using a custom template anymore.

Comment by Michael Mühlebach [ 04/Nov/15 ]

Given the thousands of other issues we have open that are more highly requested, we won't be able to address this issue in the foreseeable future. Instead we will focus on issues with a higher impact, and more votes.
Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for some time now with very little movement.
I'm going to close this to set expectations so the issue doesn't stay open for years with few updates. If the issue is still relevant please feel free to reopen it or create a new issue.

Generated at Mon Feb 12 05:57:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.