[MGNLINTEMPL-29] Javascript breaks rendering in IE 8 Created: 25/Jan/13  Updated: 16/Apr/13  Resolved: 07/Feb/13

Status: Closed
Project: Magnolia In-place templating Module (closed)
Component/s: None
Affects Version/s: 1.3.1, 1.3.2
Fix Version/s: 1.3.3

Type: Bug Priority: Major
Reporter: Jan Christian Haddorp Assignee: Jaroslav Simak
Resolution: Fixed Votes: 4
Labels: browser_issue
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

http://demo.magnolia-cms.com/.magnolia/pages/adminCentral.html


Attachments: PNG File admin_error.png     PNG File admin_ie.png     File templates.js    
Issue Links:
causality
caused by MGNLINTEMPL-21 Automatic versioning on save. Closed
caused by MGNLINTEMPL-26 Add diff support for versioned templates Closed
dependency
duplicate
is duplicated by MAGNOLIA-4816 mgnlTree not defined in IE8 Closed
is duplicated by MGNLINTEMPL-30 The DAM control in dialogs displays a... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Is it possible that the Magnolia admin cannot be used with Internet Explorer.
We are using IE8 and have tested with different computers on our own site as well as on the Magnolia Demo site.

Issue was introduced in MGNLINTEMPL-21. There is a comma after last method and IE 8 can't handle it.

+    simpleSearch: function(val){
+        if(document.mgnlForm &&  document.mgnlForm.searchStr){
+            if(document.mgnlForm.searchAdvanced){
+               document.mgnlForm.searchAdvanced.value = "false";
+            }
+            document.mgnlForm.searchStr.value = val;
+            document.mgnlForm.submit();
+        }
+        else{
+            document.location = contextPath + '/.magnolia/pages/templatesSearchList.html?searchStr=' +val;
+        }
+    }, // this comma is causing javascript problems in IE 8


 Comments   
Comment by Melodee Joy Hoene [ 07/Feb/13 ]

I currently have this issue and it is affecting production. How can I implement this fix? I'm currently running 4.5.7

Comment by Jaroslav Simak [ 08/Feb/13 ]

Hi,

i attached file called templates.js to this ticket. Download this file and put it into your /WEB-INF/classes/mgnl-resources/js-classes/mgnl/templates folder. Then restart your instance, clean cache and IE 8 should work fine again.

Cheers,
Jaroslav

Generated at Mon Feb 12 05:57:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.