[MGNLLDAP-79] Should be less lenient with configuration errors Created: 17/Jul/13  Updated: 17/Mar/21  Resolved: 17/Mar/21

Status: Closed
Project: LDAP Connector
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Magnolia International Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: architecture
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

If the jndi.ldap.config property isn't set, for example, LdapUserManager.getUser() just logs a warning and returns null. IMO it should just throw an exception. The system could be running for a while before someone notices something is wrong with the configuration.
I'm sure there are a whole bunch of places where this happens, so I'm opening this ticket to try and collect/review them all.



 Comments   
Comment by Magnolia International [ 17/Jul/13 ]

Here's another example:
info.magnolia.jaas.sp.ldap.LDAPUserManager#populateRoleListByRoleResolver:

} catch (Throwable t) {
    log.error("Failed to resolve roles assigned", t);
}
Comment by Milan Divilek [ 02/Dec/13 ]

Then this is not only LDAPUserManager issue. info.magnolia.cms.security.MgnlUserManager#getUser also just log RepositoryException and return null.

Generated at Mon Feb 12 02:21:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.