[MGNLLIC-47] CLONE - Memory-Leak/Classloader errors because BouncyCastleProvider is registrated for all WARs Created: 10/Oct/13  Updated: 22/Oct/13  Resolved: 21/Oct/13

Status: Closed
Project: Magnolia License
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3.3, 1.4.1

Type: Bug Priority: Major
Reporter: Markus Grieder Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

all os


Issue Links:
Cloners
clones MAGNOLIA-5248 Memory-Leak/Classloader errors becaus... Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: 5.1.1

 Description   

The registration of BouncyCastleProvider in info.magnolia.license.KeyGenerator and info.magnolia.license.LicenseProcessor with "Security.addProvider(new BouncyCastleProvider());" is changing JVM-settings and therefore all WARs in an Appserver are seeing this registration and classes of BouncyCastle.
If another WAR wants to use another version of BouncyCastle this can lead to Classloader issues. The Provider is also not removed on WAR-undeploy -> Memory-Leak.

In a WAR "Security.addProvider()" should be never used, because of all side-effects for other WARs ->



 Comments   
Comment by Milan Divilek [ 16/Oct/13 ]

Needs backport to 1.3.3

Comment by Jan Haderka [ 18/Oct/13 ]

test? You should be able to get the list of available security providers, then load the KeyGenerator class and check that list to see that nothing changed.

Comment by Jan Haderka [ 22/Oct/13 ]

There are easier and more efficient ways how to compare items in two lists. You can use removeAll(otherList) or retainAll(otherList)

Generated at Mon Feb 12 06:00:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.