[MGNLLIC-51] Magnolia stops working when license is expired Created: 03/Mar/14 Updated: 01/Jul/15 Resolved: 18/Jun/15 |
|
| Status: | Closed |
| Project: | Magnolia License |
| Component/s: | Checker |
| Affects Version/s: | 1.2, 1.3.2 |
| Fix Version/s: | 1.3.5, 1.4.3 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Philip Mundt | Assignee: | Evzen Fochr |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Magnolia EE 4.4 |
||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
We have to verify on the above "affected versions" that the system doesn't stop working if the license is expired. The proposed solution is to prolong the public site functioning by two extra weeks after the licence has expired. |
| Comments |
| Comment by Jan Haderka [ 16/Jun/15 ] |
|
-why is ctor deprecated from 1.5.4 and getInstance() from 1.4.3 when you have added both of those now?
Other than that looks good. thx for the quick fix. |
| Comment by Jan Haderka [ 16/Jun/15 ] |
|
now that code is simplified and easy to read, you can see that the condition can be simplified further and you don't need to check whether or not it is admin in the second part. (Either it is admin server and has to expire on short time or not and has to be checked against prolonged time or it is not expired thus it will not failed on prolonged check anyway)
if ((serverConfiguration.isAdmin() && expirationTimeInMillis < now) || expirationProlonged < now) {
|
| Comment by Philip Mundt [ 19/Jun/15 ] |
|
When integrating, please add final moidifier to member variable serverConfiguration. |