[MGNLLIC-52] Update version of commons-lang to 3.x Created: 26/Nov/14 Updated: 18/Feb/15 Resolved: 05/Feb/15 |
|
| Status: | Closed |
| Project: | Magnolia License |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.5 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Michael Mühlebach | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: | |
| Epic Link: | Update commons-lang to 3.1 |
| Description |
|
We're still using commons-lang 2.4 (released in 2008). We should upgrade to the latest version (3.1 right now). Caution: new version also got new group- and artifactId: <dependency> <groupId>org.apache.commons</groupId> <artifactId>commons-lang3</artifactId> <version>3.1</version> </dependency> License is not using commons-lang directly but over transitive dependencies of magnolia-core. As soon as license is updated to the 5.4 line it will break because of the removed commons-lang 2.x version. |
| Comments |
| Comment by Philip Mundt [ 05/Feb/15 ] |
|
1.5 was done in this commit: https://git.magnolia-cms.com/gitweb/?p=enterprise/license.git;a=commitdiff;h=340a814168268e857a3a2fe76c224a2e58dfd766 |
| Comment by Philip Mundt [ 05/Feb/15 ] |
|
1.4.3 was done in this commit: https://git.magnolia-cms.com/gitweb/?p=enterprise/license.git;a=commitdiff;h=963f9281aa58f403461dae29e35104168f6a1161 |
| Comment by Mikaël Geljić [ 06/Feb/15 ] |
|
unclear at the moment whether we want to do that on maintenance branches too |
| Comment by Mikaël Geljić [ 18/Feb/15 ] |
|
Now clear. License module 1.4.x is also used on the Magnolia 5.2 branch, i.e. before we introduced commons-lang3 anywhere. Hence we just don't do it there, removing fix-version. |