[MGNLMAIL-62] Synchronize dependency in pom.xml and in module descriptor Created: 21/Jul/14  Updated: 07/Aug/18  Resolved: 07/Aug/18

Status: Closed
Project: Magnolia Mail Module
Component/s: None
Affects Version/s: 5.2
Fix Version/s: 5.2.x

Type: Bug Priority: Neutral
Reporter: Christoph Meier Assignee: Viet Nguyen
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLMAIL-67 Split out app functionalities into a ... Open
dependency
depends upon MGNLMAIL-91 Dependency to commenting Closed
relation
is related to MAGNOLIA-5840 magnolia-empty-webapp should not depe... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Mail module should either depend on dam-core (in pom.xml), or on dam-api instead of dam-core (in module descriptor).



 Comments   
Comment by Viet Nguyen [ 03/Aug/18 ]

We will update the dependencies accordingly when splitting mail modules in MGNLMAIL-67

Comment by Viet Nguyen [ 07/Aug/18 ]

We'll combine this ticket and MGNLMAIL-91 to save verification time and efforts.

Comment by Viet Nguyen [ 07/Aug/18 ]

After investigation, currently (mail 5.5) the module depends on
dam-api for Java code of info.magnolia.module.mail.app.verify.MailVerifyPresenter
dam-app for bootstrapping of /modules/mail/apps/mail/subApps/verify/formDefinitions/simple/tabs/simple/fields/attachment/identifierToPathConverter@class=info.magnolia.dam.app.assets.field.translator.AssetCompositeIdKeyTranslator

Even though we have Unify maven dependency and magnolia modules dependency here, we had not implemented it yet.

So dependencies in Maven POM means we're using those Java classes and dependencies in Module descriptor means the bootstrapping sequence and implicit dependency.

Since mail module still working and waiting for split, this issue could not be fixed properly. We'll close it here, it would automatically fixed after we successfully unified the 2 definitions and splited the module.

Generated at Mon Feb 12 06:03:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.