Migrate TemplateScripts Task
(MGNLMIGRATION-112)
|
|
| Status: | Closed |
| Project: | Migration 4.4 to 4.5 (closed) |
| Component/s: | None |
| Affects Version/s: | 1.1.3 |
| Fix Version/s: | 1.2 |
| Type: | Sub-task | Priority: | Neutral |
| Reporter: | Eric Hechinger | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Date of First Response: |
| Description |
|
Groovy class: |
| Comments |
| Comment by Cesar Desales [ 06/Nov/12 ] |
|
Both Files have already been translated from Groovy to Java. TemplateScript => TemplateScriptParser Please elaborate on the description of the issue if additional details need to be considered or implemented. |
| Comment by Cesar Desales [ 06/Nov/12 ] |
|
Except for the problem described in |
| Comment by Jan Haderka [ 02/Dec/12 ] |
|
MigrateTemplateExecuteScripts.groovy 16 modulesMap = ["standard-templating-kit", "/Users/erichechinger/Dev/Temp/templates/templating-kit"] That doesn't seem right, does it? JspTemplate 788
789 // TODO: attributes.get("items")
790
1132 if (!path.isEmpty()) {
1133 //FIXME: ctx variable is not exposed?!
1204 //FIXME: relative link
1205 }
1206
1207 //TODO escapeXml, lineBreak, dateLanguage, scope
Pls no more todo's or fixme's - create tickets for those things if you can't do them directly. FreemarkerTemplate: 468 if (t.data.equals("@cmsu.table")) {
469 //do tables manually, lazy
470 // TODO
471 }
472
473 if (t.data.equals("@cmsu.xmp")) {
474 // TODO
475 }
864
865 // TODO: attributes.get("items")
866
The least you should do is spit out a warning about those not being migrated. 933 if (!newBarExists) {
934 //if (!areaTag.isArea) {
935 markAsArea(this.root, areaName, t, t);
936 t.addAfter(areaTag);
937 //}
IF the code is worng them remove it, don't leave it in commented out. 1280 //FIXME: relative link
1281 }
1282
1283 if (attributes.containsKey("defaultValue")) {
1284 defaultValue = "!" + wrapNull(attributes.get("defaultValue"));
1285 } else {
1286 defaultValue = "!";
1287 }
1288
1289 //TODO escapeXml, lineBreak, dateLanguage, scope
... more todo's and fixme's JSPTemplate 197 // todo? dunno, you tell me? 395 if (t.data.equals("cmsu:table")) {
396 //do tables manually, lazy
397 // TODO
398 }
399
400 if (t.data.equals("cmsu:xmp")) {
401 // TODO
402 }
same as above - at the very least print warning. TemplateScriptParser 95 if (!file.exists()) {
96 // l.logM("Template script not found! " + absolutePath, 1) TODO MGNLMIGRATION-75:
97 return;
if you are not going to print this message then remove the code ... btw |