[MGNLMIGRATION-157] ftl-Migration: Fix migration of stk.inheritContent(..) Created: 29/Oct/12  Updated: 04/Dec/12  Resolved: 04/Dec/12

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.2

Type: Bug Priority: Neutral
Reporter: wolf bubenik Assignee: Cesar Desales
Resolution: Not an issue Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

The replacement of

inherited = stk.inheritContent(content, "somePooperty")

does not work. It should be replaced by

inherited = cmsfn.inherit(model.node, "somePooperty")

or something similar that provides the current content as Node instead of ContentMap.



 Comments   
Comment by Cesar Desales [ 05/Nov/12 ]

The change seems to have been already implemented in 1.2 as the following migration happens:

assign iconLinksModel = stk.inheritContent(content, "iconLinks") /

assign iconLinksModel = cmsfn.inherit(content.iconLinks) /

Comment by Samuel Schmitt [ 07/Nov/12 ]

Cesar did you check that a call to cmsfn.inherit(content.iconLinks) is working as expected.
Then, if yes, you could set the issue as resolved.

Comment by Cesar Desales [ 15/Nov/12 ]

At the moment it's not possible to make cmsfn.inherit work in any of the cases mentiones above:

[#assign mytitle = cmsfn.inherit(content, "siteTitle")]
[#assign mytitle = cmsfn.inherit(content.siteTitle)]

The problems I've ran into are not caused by lack of content as the following expressions cause no errors:

[#assign inhContent = cmsfn.inherit(content)]
[#assign mytitle = cmsfn.inheritProperty(content, "siteTitle")]
${content.siteTitle}
${inhContent.siteTitle}
Comment by Cesar Desales [ 15/Nov/12 ]

Both expressions work. The reason for them to fail was that inherit() is meant to be applied to nodes instead of properties (siteTitle is a property).

The changes made by the Migration Tool are thus correct.

Comment by Jan Haderka [ 29/Nov/12 ]

which commit fixes this? If you forget to add issue title in the commit message you have add link or hash from git commit to issue comment directly.

Comment by Cesar Desales [ 04/Dec/12 ]

I'm changing the resolution status, it was never an issue, nevertheless I had to demonstrate it. Therefore there's no commit as there's nothing to fix.

Generated at Mon Feb 12 10:17:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.