[MGNLMIGRATION-158] Exclude duplicated entry for antlr.jar Created: 30/Oct/12 Updated: 28/Feb/14 Resolved: 09/Nov/12 |
|
| Status: | Closed |
| Project: | Migration 4.4 to 4.5 (closed) |
| Component/s: | None |
| Affects Version/s: | 1.1.5 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Robert Šiška |
| Resolution: | Not an issue | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
In the tomcat-bundle we have a duplicated entry for antlr.jar 3.4 and 2.7.7 the latter pulled in by stringtemplate.jar. antlr is brought in by magnolia-4-5-migration module. |
| Comments |
| Comment by Robert Šiška [ 09/Nov/12 ] |
|
The antlr-3.4 depends on antlr-runtime-3.4, which depends on There is no collision of dependencies, it's dependency of antlr itself. See: http://www.antlr.org/antlr3-maven-plugin/dependencies.html |
| Comment by Edgar Vonk [ 28/Feb/14 ] |
|
Hi @rsiska, I came across this issue too. Not just in the Magnolia 4.5 Migration Module but also in the standard Magnolia 5.2.2 enterprise WAR. Every Magnolia WAR now has 2 antlr libraries (so runtime dependencies) in WEB-INF/lib:
I would guess that it would be good to exclude the old antlr transitive dependency from Magnolia somehow? As you say the stringtemplate lib is the issue. Multiple versions of the same runtime dependency cannot be a good thing. |
| Comment by Edgar Vonk [ 28/Feb/14 ] |
|
Even if there might not be any collisions: the main issue is that most Magnolia Java developers will come across this issue and will want to solve it, having learned to always have 1 version of a runtime dependency. It therefore will cost time to everyone.. |