[MGNLMIGRATION-164] The FTL migration and area extraction code should report the code to be added to the version handler. Created: 08/Nov/12  Updated: 07/Dec/12  Resolved: 07/Dec/12

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2

Type: Improvement Priority: Critical
Reporter: Philipp Bärfuss Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Instead of creating a groovy script the outcome are few lines of code to add to the version handler along the base migration update tasks.

Use the NodeBuilderTask for this.



 Comments   
Comment by Robert Šiška [ 15/Nov/12 ]

I decided to write new task, instead of using NodeBuilderTask. The output is much shorter and more readable.

Comment by Jan Haderka [ 29/Nov/12 ]
+                        // TODO: set dialog property, for stk areas

Don't see any issue associated to that TODO. There should be issue linked with original issue for left over work or there should be no left over work.

catch (Exception e)

Please do not catch generic exception. It will catch also OOME and other kind of errors which should not be caught.

Comment by Jan Haderka [ 07/Dec/12 ]
TemplateScriptParser:
                } catch (Exception e) {
+                    if (e instanceof IOException || e instanceof RepositoryException 
+                            || e instanceof PathNotFoundException || e instanceof ValueFormatException) {
  • how is this better then multiple catch clauses? And what if there is some other error like OOME? You just eat it up silently? This is wrong on many different levels.

and same again:

TemplateScriptMigrationTask
+        } catch (Exception e) {
+            if (e instanceof IOException || e instanceof RepositoryException || e instanceof TemplateErrorException) {
+                result = "Can't find path of the template script! " + e.getMessage();
+                parsingFailed.add(templateId);
+                reportService.report(this, ReportingLevel.ERROR, "Error while opening/finding script of " + templateId);
+            }
Generated at Mon Feb 12 10:17:46 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.