[MGNLMIGRATION-203] Migration of FTL should not be triggered on Magnolia startup Created: 09/Jan/13  Updated: 24/Jan/13  Resolved: 23/Jan/13

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: 1.2
Fix Version/s: 1.2.1

Type: Improvement Priority: Major
Reporter: Natascha Desmarais Assignee: Samuel Schmitt
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-4769 Remove magnolia.update.stkMigration f... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Right now if you set magnolia.update.stkMigration on true in the magnolia.properties you could trigger the migration of the FTL on startup. This is a bit confusing, could lead to issues and also not recommended by the migration process. For all these reason we must remove this mechanism.

Under certain circumstances, when there is a magnolia.update.stkMigration properties present in any magnolia.properties, the installation of the module will fail with

Could not install or update magnolia-4-5-migration module. Task 'Trigger migration scripts' failed. (IOException: Can't find resource file at /scripts/migration/from4_4To4_5/ConfiguredMigration.groovy)

This is due to the fact that the getExtrasInstallTasks function still references an old file that doesn't exist anymore in the 1.2 version of this module. Looking closer at the whole VH, it should be revised and updated to not even consider the property magnolia.update.stkMigration since this has been removed altogether.



 Comments   
Comment by Samuel Schmitt [ 11/Jan/13 ]

And magnolia.update.stkMigration must be removed from magnolia.properties

Comment by Samuel Schmitt [ 11/Jan/13 ]

In my commit (01a54a1bcead84416a2c47e48aca34bceeeb7587) I referenced the wrong ticket...

Comment by Jan Haderka [ 23/Jan/13 ]

The above mentioned commit is about EOL change in extends_comparison.properties not about not triggering ftl migration, so where is the commit w/ changes described in this ticket?

Comment by Samuel Schmitt [ 23/Jan/13 ]

The associated commit is this one:

Commit
01a54a1bcead84416a2c47e48aca34bceeeb7587
Branch
master
Author
Samuel Schmitt <samuel.schmitt@magnolia-cms.com>
Date
Fri, 11 Jan 2013 15:23:33 +0100
Message
MGNLMIGRATION-206: migration of the FTL cannot be triggered anymore on
startup of Magnolia.

The message use MGNLMIGRATION-206 but it should has used MGNLMIGRATION-203.

Comment by Jan Haderka [ 24/Jan/13 ]

Hmm, sorry. search for given commit in web interface returns wrong result. Didn't notice this before.

Generated at Mon Feb 12 10:18:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.