[MGNLMIGRATION-240] modules named with xxx-templates/ fail to migrate correctly Created: 06/May/13  Updated: 29/May/13  Resolved: 14/May/13

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: 1.2.2
Fix Version/s: 1.2.2

Type: Bug Priority: Neutral
Reporter: Karel de Witte Assignee: Karel de Witte
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Due to a slight bug in info.magnolia.migration.task.general.IdCreationMigrationTask.createNewTemplateId(String) modules that ended with templates were not migrated correctly, changed StringUtils.substringAfter(templateHandle, "templates/"); with StringUtils.substringAfter(templateHandle, "/templates/");



 Comments   
Comment by Karel de Witte [ 06/May/13 ]

Bug fix description in initial comment

Comment by Jan Haderka [ 13/May/13 ]

Again separate code changes from formatting and commit them separately. Also AFAIK no one has so small editor that we would need to wrap comments at 80 chars ... whichever IDE you are using, there's preferred configuration for code formatting on the wiki, please use it.

Junit tests are missing.

Comment by Karel de Witte [ 14/May/13 ]

Added unit test on idcreationmigrationtask's idcreation method

Comment by Jan Haderka [ 14/May/13 ]

Thx for test. BTW we try to use //GIVEN //WHEN //THEN for tests to make them easier to read in a long run. see e.g. https://git.magnolia-cms.com/gitweb/?p=magnolia_main.git;a=blob;f=magnolia-rendering/src/test/java/info/magnolia/rendering/engine/RenderingFilterTest.java;h=baab11712010c36cfe50b54e247081a277f213e4;hb=baab11712010c36cfe50b54e247081a277f213e4

Comment by Roman Kovařík [ 29/May/13 ]

IdCreationMigrationTaskTest was missing on 1.2.x branch. Ported under MGNLMIGRATION-243.

Generated at Mon Feb 12 10:18:29 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.