[MGNLMIGRATION-241] unexisting paths in postmigration task interrupted the migration Created: 06/May/13 Updated: 23/Sep/13 Resolved: 14/May/13 |
|
| Status: | Closed |
| Project: | Migration 4.4 to 4.5 (closed) |
| Component/s: | None |
| Affects Version/s: | 1.2.2 |
| Fix Version/s: | 1.2.2 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Karel de Witte | Assignee: | Karel de Witte |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
there was no parent path checking in info.magnolia.migration.task.general.AbstractPostMigrationTask.changeProperty(InstallContext, String, Map<String, String>) which made the migration task fail on unexisting paths described in properties, correction adds this check |
| Comments |
| Comment by Karel de Witte [ 06/May/13 ] |
|
bug fix description in initial comment |
| Comment by Jan Haderka [ 13/May/13 ] |
|
It would be great for the next time if you commit formatting changes separately from code changes otherwise they are obscured and difficult to find (unless obfuscating the diff is what you really aim for Do we really need to both log the warning and report issue to the reporting? Should be enough to just report it since report ends up in the logs anyways right? Also the junit test is missing. |
| Comment by Karel de Witte [ 14/May/13 ] |
|
added unit test on PostMigrationTask, should not fail but report unfound properties |
| Comment by Roman Kovařík [ 29/May/13 ] |
|
AbstractPostMigrationTaskTest was missing on 1.2.x branch. Ported under |