[MGNLMIGRATION-77] Templates in the Magnolia site definition are not migrated Created: 25/Sep/12  Updated: 29/Mar/13  Resolved: 10/Oct/12

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: 1.1.4
Fix Version/s: 1.1.4

Type: Bug Priority: Blocker
Reporter: Lars Fischer Assignee: Cesar Desales
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLMIGRATION-159 Templates in the Magnolia site defini... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Testing with the Coop project, the main.ftl script defined in the Magnolia site definition is still not migrated.

We should fix that asap, because it's the most important script.



 Comments   
Comment by Natascha Desmarais [ 25/Sep/12 ]

I moved this up to blocker priority. If the main.ftl script does not work, then the rest cannot work either in real projects. This is one of the bugs that has to be done for the first training / next release for sure.

Comment by Lars Fischer [ 25/Sep/12 ]

It seems to work for STK only though, just not for individual sites. I could run the scripts on the training stuff and could open the home page afterwards.

Comment by Natascha Desmarais [ 25/Sep/12 ]

The training does not introduce a special main.ftl in the site definition (unlike coop) but only in a page template (section) - that's why it's working.

Comment by wolf bubenik [ 05/Oct/12 ]

A related issue we have in the Migros project. FTL-files referenced in the site definition are not migrated.
Furthermore we reference ftl files in more than one module! As I understand the migration scripts we have to provide a list of defaultTemplateScriptsPath entries, not only one.

You may consider to extend the migration scripts as already done for the custom module templateScriptsPath.

Comment by Lars Fischer [ 05/Oct/12 ]

At least when you have one template like "main.ftl" in the site definition then it will be migrated if you define the corresponding path in "defaultTemplateScriptsPath" in your Configuration.groovy script.

Comment by wolf bubenik [ 05/Oct/12 ]

Yes, the main.ftl from module migros-common-templating is migrated. But not the other referenced ftls from the same module (branding.ftl, htmlHeader.ftl, editableHorizontalNavigation.ftl).

Comment by Cesar Desales [ 10/Oct/12 ]

The Migration Tool has been modified to read all template scripts referenced from the site definition

Comment by Jan Haderka [ 29/Mar/13 ]

Closing all issues resolved and released in 1.1.x versions w/o further review. (current latest version is 1.2.2)

Generated at Mon Feb 12 10:16:56 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.