Migrate TemplateScripts Task (MGNLMIGRATION-112)

[MGNLMIGRATION-80] When using template script from Magnolia modules, provide areas of these templates without parsing the FTL. Created: 27/Sep/12  Updated: 06/Mar/13  Resolved: 04/Mar/13

Status: Closed
Project: Migration 4.4 to 4.5 (closed)
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2.1

Type: Sub-task Priority: Neutral
Reporter: Robert Šiška Assignee: Robert Šiška
Resolution: Fixed Votes: 0
Labels: ToDo_for_1_2_1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:

 Description   

In the time of running migration tool on custom project, all the Magnolia modules like stk, form or pur can be already migrated.

When custom modules use FTLs from these modules, areas should be "detected" without need of parsing the old versions of these FTLs.

Also, when extending template definition with area, copy the area definition and add available components.



 Comments   
Comment by Eric Hechinger [ 20/Dec/12 ]

@Robert: Could you check the status of this ticket (Open, but commit!)

Comment by Jan Haderka [ 24/Jan/13 ]
  • I fail to see how is this useful. Can you explain (or better remove it)?
  • MigrationUtil.groovy)) {{travelExtends() method. What is this name? Where do you want to have extend to travel? If I got right what it does, it should be call traverseExtendsNodeHierarchy() or similar, but not travel.
  • TemplateScript.groovy please stop using one letter variables in the code such as
      LogUtil l
    

    and no, renaming it to lu is not ok either. Think of anyone who will have to read this code and maintain it half a year later.

  • TemplateScriptParser.java - rather then commenting out exception, remove it and add comment explaining why returning null in this case is what we want to do.
             if (isSTKTemplateScript(templateScriptPath)) {
    -          throw new Exception("Extending STK script!");
    +            //throw new Exception("Extending STK script!");
    +            return null;
             }
    

General remark:

  • if you want to reorder methods in the code, do it in separate commit and make sure commit message explains it. It is nearly impossible to look at one letter changes in the code between hundreds of reordered lines.
Comment by Robert Šiška [ 04/Mar/13 ]

@Jan All points have been resolved in the meantime by other tickets...

Generated at Mon Feb 12 10:16:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.