[MGNLMODSTR-5] Cannot go to admincentral from domain root or rendered page on author Created: 19/Nov/13 Updated: 09/Sep/15 Resolved: 19/Sep/14 |
|
| Status: | Closed |
| Project: | Modifystream (closed) |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Zdenek Skodik | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Description |
|
Doing domain mapping is a productivity boost and a time-saver for the team. However since 5.0 we return a page in preview fashion if editor access the site via a domain mapped to it, disallowing her to edit any content right away or switch to AdminCentral with one click. To reproduce:
4.5 behavior was to directly display the page too, but being logged in meant for the user to be in edit-mode. The new page editor is bound to the page app, thus cannot run "standalone". |
| Comments |
| Comment by Philip Mundt [ 22/Nov/13 ] |
|
What options do we have?
|
| Comment by Philip Mundt [ 12/Dec/13 ] |
|
Related to |
| Comment by Mikaël Geljić [ 29/Jan/14 ] |
|
Moving this issue to 1.0.x - we need further specification before anything happens there. |
| Comment by Mikaël Geljić [ 03/Apr/14 ] |
|
Clarifying this issue by rephrasing title and shedding some light after a couple of rounds of investigation. This issue has the two following flavors: 1. From site domain root, after login we are currently redirected to such site's root page. 2. From a rendered page on author, there's nothing to go straight to the admincentral's pages app so that I can edit that page directly. |
| Comment by Jan Haderka [ 06/Apr/14 ] |
|
The option 1 is not working for the root/home page. You would be never able to see it, since link generated in menu is http://yourdomain/ which would then redirect you back to admin central. |
| Comment by Milan Divilek [ 16/Apr/14 ] |
|
3. Re-introduce a green button which redirects to admincentral. It will be done by introducing filter which will add div with "admincentral" button into body of all pages (except .magnolia). Filter could be easily enable/disable and also of format of div with "admincentral" button will be configurable. |
| Comment by Philip Mundt [ 14/Jul/14 ] |
|
Setting fixVersion to "1.0.x" as this issue will not be fixed in the maintenance release of "1.0.5". |
| Comment by Milan Divilek [ 18/Jul/14 ] |
|
committed proposal of the module which inject admincentral button |
| Comment by Jan Haderka [ 21/Jul/14 ] |
|
Looks good in general, but:
|
| Comment by Milan Divilek [ 23/Jul/14 ] |
Checking fragments is done during writing byte to output stream. If we would want to use regex then this would have to be changed -> write whole stream and then do the check for fragment and injection. And in this case it would be probably better use some 3rd party library (probably jsoup) which allows find data using DOM traversal or CSS selectors.
I changed name of module to magnolia-injection-filter, because it can be used for injection of any code into stream not only the admin central button. Is this name ok? If yes I'll move it to forge |
| Comment by Jan Haderka [ 24/Jul/14 ] |
|
add 1) ok |
| Comment by Roman Kovařík [ 18/Aug/14 ] |
|
Solution |
| Comment by Jan Haderka [ 12/Sep/14 ] |
|
Where's the code? (Not the original commit in your private repo, but the one in target repo w/ updated pom and ready to be released) |
| Comment by Roman Kovařík [ 19/Sep/14 ] |
|